Wireshark-bugs: [Wireshark-bugs] [Bug 11980] The filtering speed is impacted by commit b344107d7
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Sun, 10 Jan 2016 13:50:05 +0000

Comment # 6 on bug 11980 from 
You are right, coloring always need to happen (whenever color rules exist).
(What about tshark? Colors are normally not shown, but if the two
frame.coloring_rule fields are shown in the frame tree/columns, should the
color calculation also be done?)

For a start, to calculate on the first pass (pinfo->fd->flags.visited == 0).
This did not work because the fields from the color filter are not primed yet.
Possible fix: always invoke dfilter_prime_proto_tree before
epan_dissect_run{,_with_taps} (similar to epan_dissect_prime_dfilter).

The next problem is that the applicable color may change during subsequent
redissections.
Possible fix: introduce a new fd->flags.need_colorize which must be set before
the initial dissection in GUI and again after changing color rules. Clear flag
after after recalculation.
Alternative fix: introduce a new global flag (eww), that behaves similar to the
previous fix, but outside frame_data.

Those fixes will then bring the coloring rules at the same level as display
filter rules, allowing filtering as well.

You are receiving this mail because:
  • You are watching all bug changes.