Wireshark · Wireshark-bugs: [Wireshark-bugs] [Bug 11596] wireshark crashes when using the voip player.

[bugzilla-daemon@xxxxxxxxxxxxx]

Comment # 5 on bug 11596 from gerlof.fokkema@gmail.com

So the problem is this piece of code:

diff --git a/ui/voip_calls.c b/ui/voip_calls.c
index a673fde..d452039 100644
--- a/ui/voip_calls.c
+++ b/ui/voip_calls.c
@@ -433,7 +433,7 @@ static void insert_to_graph_t38(voip_calls_tapinfo_t
*tapinfo, packet_info *pinf
     gchar     time_str[COL_MAX_LEN];

     new_gai = (seq_analysis_item_t *)g_malloc0(sizeof(seq_analysis_item_t));
-    new_gai->fd = packet_list_get_row_data(frame_num);
+    new_gai->fd = pinfo->fd; // packet_list_get_row_data(frame_num);
     COPY_ADDRESS(&(new_gai->src_addr),src_addr);
     COPY_ADDRESS(&(new_gai->dst_addr),dst_addr);

I know this diff is incorrect in that new_gai now contains wrong frame_data,
but at least it doesn't crash.
The source of the problem is that frame_num is used as an index into the
underlying gtk tree view model.
However, when you filter that tree model, then the indices adjust accordingly.
Therefore using frame_num as an index results in crashes.

Can somebody point me in the right direction on how to retrieve frame_data
without querying the gui as a datasource?

---

      You are receiving this mail because:

• You are watching all bug changes.