Wireshark · Wireshark-bugs: [Wireshark-bugs] [Bug 11478] Suspected Duplicate MAC detected in RTP analysis

[bugzilla-daemon@xxxxxxxxxxxxx]

Jim Young changed bug 11478

What	Removed	Added
Status	UNCONFIRMED	CONFIRMED
CC		jyoung@gsu.edu
Ever confirmed		1

Comment # 3 on bug 11478 from Jim Young

There's an explicit check for this in ui/tap-rtp-common.c but I can't really
understand why its there.  If I comment out the block then the rtp analysis
works as expected.

diff --git ui/tap-rtp-common.c ui/tap-rtp-common.c
index b164c39..bef73ee 100644
--- ui/tap-rtp-common.c
+++ ui/tap-rtp-common.c
@@ -460,6 +460,7 @@ int rtp_packet_analyse(tap_rtp_stat_t *statinfo,
        statinfo->flags = 0;

        /* Chek for duplicates (src mac differs from first_packet_mac_addr) */
+#if 0
        if( pinfo->dl_src.type == AT_ETHER){
                if(!ADDRESSES_EQUAL(&(statinfo->first_packet_mac_addr),
&(pinfo->dl_src))){
                        statinfo->flags |= STAT_FLAG_DUP_PKT;
@@ -467,6 +468,8 @@ int rtp_packet_analyse(tap_rtp_stat_t *statinfo,
                        return 0;
                }
        }
+#endif
+

If this piece of code is really necessary (someone at one time believed it was)
then we should probably have a preference to enable/disable this src mac
address differs check.

---

      You are receiving this mail because:

• You are watching all bug changes.