Wireshark-bugs: [Wireshark-bugs] [Bug 11126] The GIOP dissector displays \000 at the end of op s
Evan Huus
changed
bug 11126
| What |
Removed |
Added |
| CC |
|
eapache@gmail.com
|
Comment # 3
on bug 11126
from Evan Huus
This one's kinda weird. Two points:
- the protocol descriptions I have found (no official spec, sadly) all seem to
imply that CDR strings are not null-terminated (they are definitely counted
strings, and there is no mention of null-termination)
- get_CDR_string is adding a null-terminator, but is already not returning that
as part of its length (so if it sees a string of length 4 it will put it in a
buffer of length 5 with a null-terminator, but it will still only return 4)
So based on the above, if something is putting a null-terminated string on the
wire, we'll show the null, but I think that's the right thing to do.
Unless/until somebody shows me a spec where it states that CDR strings should
be null-terminated, a program that encodes them as such seems to be doing extra
work for nothing.
You are receiving this mail because:
- You are watching all bug changes.
