Wireshark · Wireshark-bugs: [Wireshark-bugs] [Bug 11009] cmake fails to configure if libusan not installed

[bugzilla-daemon@xxxxxxxxxxxxx]

Comment # 15 on bug 11009 from Guy Harris

(In reply to Jörg Mayer from comment #14)
> We validate the compile/link flags we pass to the build proces, including
> those that the user specified via CFLAGS or whatever.

"We" the configure script?  If so, it's not by intent, it's by chance; with
clang as the compiler (CC=clang), my example CFLAGS setting *worked*, it didn't
fail until compile time, and that only because it was building with -Werror and
clang's normal "argument unused during compilation" warning was, instead,
treated as an error.

If we're going to care about validating compiler/linker flags, we should do so
*explicitly*, rather than rely on the "checking whether the C compiler works"
stage to validate the flags (the "checking whether the XXX compiler works" test
is done in the process of trying to figure out the extension used for the
default executable name, e.g. ".out"; see lib/autoconf/lang.m4 in the autoconf
source), as that's not guaranteed to detect problems with the flags (not even
with the *compiler* flags, as it relies on the compiler failing, rather than
just printing a warning, for all unknown flags; clang, for better or worse,
prints only a warning for some flags, e.g. unknown -f and -W flags).

---

      You are receiving this mail because:

• You are watching all bug changes.