Matthijs Kooijman
changed
bug 10783
| What |
Removed |
Added |
| CC |
|
matthijs@stdin.nl
|
Comment # 11
on bug 10783
from Matthijs Kooijman
I had a look at this patch, but it's not quite there yet:
- There's a lot of inconsistent indentation
- The patch adds quite some lines of commented out (debugging) code that can
probably be left out.
- There's duplicated code. In particular, the handling of decryption errors
seems to have the same code three types, which also partly overlaps with the
handling of a missing decryption key. Some restructuring should be able to
clean that up.
- If the encryption key does not have the right format, there is no real
feedback about it. I've been doing some trial-and-error to find out that
colon-separated hex-bytes is the way to go. If the format is wrong (e.g.
without the colons) or the key is too short, it only shows "key missing" or
something similar.
After entering the right key, I get some packets which are succesfully
decrypted (though I haven't confirmed if the decrypted data is correct yet) and
some packets which show MIC failure. I'll have to doublecheck if this is a
problem in my capture or the code, I'll get back about that.
You are receiving this mail because:
- You are watching all bug changes.
