Pascal Quantin
changed
bug 10898
What |
Removed |
Added |
CC |
|
pascal.quantin@gmail.com
|
Comment # 2
on bug 10898
from Pascal Quantin
This is packet 3.
The problem comes form the fact that MEGACO dissector calls SDP dissector, and
that SDP dissector assumes that a port will always be a numerical value (which
seems logical at first glance).
So this code found in packet-sdp.c:
/* XXX Remember Port */
proto_tree_add_uint(sdp_media_tree, hf_media_port, tvb, offset,
tokenlen,
atoi((char*)tvb_get_string_enc(wmem_packet_scope(),
tvb, offset, tokenlen, ENC_UTF_8|ENC_NA)));
Does not handle (legitimately) a $ character. RFC 4566 says:
<port> is the transport port to which the media stream is sent. The
meaning of the transport port depends on the network being used as
specified in the relevant "c=" field, and on the transport
protocol defined in the <proto> sub-field of the media field.
Other ports used by the media application (such as the RTP Control
Protocol (RTCP) port [19]) MAY be derived algorithmically from the
base media port or MAY be specified in a separate attribute (for
example, "a=rtcp:" as defined in [22]).
What does a $ character means in MEGACO case?
You are receiving this mail because:
- You are watching all bug changes.