Wireshark-bugs: [Wireshark-bugs] [Bug 10805] Websocket dissector does not find subdissector corr
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Tue, 06 Jan 2015 22:23:16 +0000

Comment # 14 on bug 10805 from 
(In reply to Martin Kaiser from comment #12)
> (In reply to Yang Liu from comment #11)
> > Hi Matin,
> > 
> > Thanks for looking into this issue. I uploaded captured packets and
> > screenshots for using released and modified wireshark to dissector my
> > packets.
> > 
> > Here is the code in my dissector proto_reg_handoff_viewvc(void) function.
> > 
> >     viewvc_handle = new_register_dissector("viewvc", dissect_viewvc,
> > proto_viewvc);
> >     dissector_add_uint("ws.port", VIEWVC_PORT, viewvc_handle);
> > 
> 
> Hi Yang,
> 
> thanks for the capture file. I can reproduce the issue and I drafted a fix.
> I'll push it for review tomorrow when I have a bit more time to clean it up.

In your sample capture, we go from tcp to http because of heuristic dissection.
http is on a non-standard port. The dissector sees the Upgrade: websocket
header and passed the subsequent packets to the websocket dissector.

None of these mechanisms sets match_uint (we're not matching against a uint).
match_uint is 6 because it was last used when going from ip to tcp and tcp is
protocol number 6.

We should use the http server port as index for the dissector table.

You are receiving this mail because:
  • You are watching all bug changes.