Wireshark · Wireshark-bugs: [Wireshark-bugs] [Bug 10753] PROFINET DiagnosisData.ChannelProperties: Maintenance bit definitions s

[bugzilla-daemon@xxxxxxxxxxxxx]

Comment # 12 on bug 10753 from Petter Karlsson

Thanks Pascal, I tried the nightly and it did not fix the issue.

(In reply to Anish Bhatt from comment #11)

> Please confirm that the nightly mentioned in comment 10 is not the solution
> that is needed. Since bit 9 is required and 10 is demanded, the mask of 0x10
> for required and 0x20 for demanded seemed wrong to me as well. Perhaps both
> need to be fixed ? 

The SubmoduleState field has a different definition. The specification defines
bit 4 (0x0010) as SubmoduleState.MaintenanceRequired; bit 5 (0x0020) as
SubmoduleState.MaintenanceDemanded. From my understanding this was correct in
previous release.

> When calculating mask, 0x20 is to the left and 0x10 would be to the right.
> While counting bits, I am assuming counting begins from LHS, so demanded
> would be to the right and should have mask 0x10, required to the left would
> have mask of 0x20

Bit 0 is least significant (i.e. counting from RHS), so in the context of
pn_io_channel_properties_maintenance the correct implementation should be
according to comment #9. The changes to interpretation of SubmoduleState field
should be reverted.

---

      You are receiving this mail because:

• You are watching all bug changes.