Wireshark-bugs: [Wireshark-bugs] [Bug 10753] PROFINET DiagnosisData.ChannelProperties: Maintenan
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Mon, 05 Jan 2015 08:23:21 +0000

Comment # 9 on bug 10753 from 
Hi, sorry for (too) late reply. Unfortunately I haven't been able to find the
time to set up the build environment to try out the patch (first-time bug
reporter).

Yes, it is a bit strange for the spec to use hex values for bit definitions,
but bit 9 shall indicate "Maintenance required" and bit 10 shall indicate
"Maintenance demanded". However, note that this relates to the
ChannelProperties field and not the SubmoduleState. 
As far as I can tell, though I'm not familiar with the internals of dissector
coding, the change should rather be in the pn_io_channel_properties_maintenance
structure (line 2247), i.e.:

static const value_string pn_io_channel_properties_maintenance[] = {
    { 0x0000, "Failure" },
    { 0x0001, "Maintenance required" },
    { 0x0002, "Maintenance demanded" },
    { 0x0003, "see QualifiedChannelQualifier" },
    { 0, NULL }
};

You are receiving this mail because:
  • You are watching all bug changes.