Wireshark-bugs: [Wireshark-bugs] [Bug 10579] IP header in ICMP error checksum not checked even t
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Fri, 31 Oct 2014 19:43:44 +0000

changed bug 10579


What Removed Added
CC   ydahhrk@gmail.com

Comment # 3 on bug 10579 from 
I guess I'm going to end up as that annoying user that doesn't shut up soon
enough, but well...

Wireshark's whining has prevented several bugs from remaining unnoticed from
casual use and unit testing of my artifact. I have code that handles inner
packets, and there is a small chance that it will corrupt them without this
being visible in the outer checksum.

I mean... I've been looking at the code, and it seems all we'd have to do is
remove the second condition from the if at line 2144 of packet-ip.c (and update
the comment nearby).

For a software that goes through the trouble of decrypting and uncompressing
packets, I think the question should be "is there a good reason to not validate
this checksum?" instead of "is there a good reason to do it?".

You are receiving this mail because:
  • You are watching all bug changes.