Pascal Quantin
changed
bug 10613
| What |
Removed |
Added |
| CC |
|
pascal.quantin@gmail.com, peter@lekensteyn.nl
|
| Hardware |
x86-64
|
All
|
Comment # 3
on bug 10613
from Pascal Quantin
The crash was introduced by commit dfc005adb248bd5f46ffbc983f85fa8dcf5a2c0b
(Hack to fix RTP player progress line position), in the following hunk:
@@ -915,7 +932,14 @@ draw_channel_cursor(rtp_channel_info_t *rci, guint32
start_index)
#if PORTAUDIO_API_1
idx = Pa_StreamTime( pa_stream ) - rtp_channels->pause_duration -
rtp_channels->out_diff_time - start_index;
#else /* PORTAUDIO_API_1 */
- idx = ((guint32)(sample_rate) *
(Pa_GetStreamTime(pa_stream)-rtp_channels->pa_start_time))-
rtp_channels->pause_duration - rtp_channels->out_diff_time - start_index;
+ /* frames since start button was pressed minus latency, from time */
+ idx = (guint32) sample_rate
+ * (getCurrentTime(pa_stream) - rtp_channels->pa_start_time
+ - rtp_channels->out_diff_time);
+ /* frames spent in pause state or seek correction */
+ idx -= rtp_channels->pause_duration;
+ /* frame where the bar starts getting drawn */
+ idx -= start_index;
#endif /* PORTAUDIO_API_1 */
Here pa_stream is NULL. Pa_GetStreamTime() was handling this case gracefully,
but getCurrentTime() does not.
You are receiving this mail because:
- You are watching all bug changes.
