Wireshark-bugs: [Wireshark-bugs] [Bug 10536] smtp decoder can dump binary data to terminal in ts
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Mon, 20 Oct 2014 03:41:31 +0000

changed bug 10536


What Removed Added
Status UNCONFIRMED CONFIRMED
CC   mmann78@netscape.net
Ever confirmed   1

Comment # 2 on bug 10536 from 
The issue here is how the COL_INFO is displayed, and it has me a little
confused.

I looked at this capture file in Wireshark in both master and 1.8.  In master
(and I presume 1.12 based on submitter info), Info column is dumped as a
string, and even though its binary data, its all represented as "printable
characters" (which looks like the "garbage" the submitter copy/pasted here). 
In 1.8 branch, the Info column uses the \xxx representation for "non-printable"
characters.

In the diffs I've done, nothing jumps out at me as to why this would have
changed.  The COL_INFO went from tvb_get_ephemeral_string ->
tvb_get_string_enc, but that should just have been a "function name change".
All of the SMTP fields within the packet (FT_STRING types), use the \xxx
representation, which I thought used tvb_get_string_enc (or at least a "common"
formatting function) "under the covers".

I originally thought this was a "state machine" issue, but dissector should be
able to display "packet of SMTP binary data" (because it doesn't have enough
state info yet) as the default.

You are receiving this mail because:
  • You are watching all bug changes.