Wireshark-bugs: [Wireshark-bugs] [Bug 10558] New: DNP3 Dissector Enhancement for Obj 12 Var 2 an
| Bug ID |
10558
|
| Summary |
DNP3 Dissector Enhancement for Obj 12 Var 2 and Var 3 Objects + Bug Fix for single-bit object-types
|
| Product |
Wireshark
|
| Version |
1.11.x (Experimental)
|
| Hardware |
x86
|
| OS |
Windows 8
|
| Status |
UNCONFIRMED
|
| Severity |
Major
|
| Priority |
Low
|
| Component |
Dissection engine (libwireshark)
|
| Assignee |
bugzilla-admin@wireshark.org
|
| Reporter |
cbontje@gmail.com
|
Build Information:
Version 1.99.0 (Git Rev Unknown from unknown)
Copyright 1998-2014 Gerald Combs <gerald@wireshark.org> and contributors.
License GPLv2+: GNU GPL version 2 or later
<http://www.gnu.org/licenses/old-licenses/gpl-2.0.html>
This is free software; see the source for copying conditions. There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
Compiled (32-bit) with GTK+ 2.24.23, with Cairo 1.10.2, with Pango 1.34.0, with
WinPcap (4_1_3), with libz 1.2.5, with GLib 2.38.0, with SMI 0.4.8, with c-ares
1.9.1, with Lua 5.2, with GnuTLS 3.1.22, with Gcrypt 1.6.0, with MIT Kerberos,
with GeoIP, with PortAudio V19-devel (built Oct 1 2014), with AirPcap.
Running on 64-bit Windows 8, build 9200, with WinPcap version 4.1.3 (packet.dll
version 4.1.0.2980), based on libpcap version 1.0 branch 1_0_rel0b (20091008),
with GnuTLS 3.1.22, with Gcrypt 1.6.0, without AirPcap.
Intel(R) Core(TM) i7-3687U CPU @ 2.10GHz (with SSE4.2), with 8074MB of
physical memory.
Built using Microsoft Visual C++ 10.0 build 40219
Wireshark is Open Source Software released under the GNU General Public
License.
Check the man page and http://www.wireshark.org for more information.
--
This small patch will add functionality to decode 2 object types that I finally
ran into this week - I'd never seen them before 'in the wild'.
Object 12 Var 2 - Pattern Control Block
Object 12 Var 3 - Pattern Mask
Adding support for them is straight-forward since Obj12 Var2 uses the same
decoding as Obj12 Var1; Obj12 Var3 is a bit-based object similar to IIN reads
or Obj1 var1.
I also added in a small bug fix for single-bit object types:
Single-Bit Binary Input (Obj:01, Var:01)
Binary Output (Obj:10, Var:01)
Pattern Mask (Obj:12, Var:03)
Internal Indications - IIN (Obj: 80, Var:01)
Previously, these types would display properly in the middle decode-pane but
the point objects themselves had an incorrect 'offset' pointer into the
bottom-pane 'byte' display. The behavior was caused by a combination of when
the bitindex value was incremented, when we moved to the next byte offset after
8 bits, and when we added the point object. Previously, 9 bits would be
assigned to the first byte, then every other point object would be offset by
that single bit.
I'll attach a couple samples showing the single bit object types, as well as a
few samples of the new Obj12 decoding.
You are receiving this mail because:
- You are watching all bug changes.
