Wireshark-bugs: [Wireshark-bugs] [Bug 10545] "BROWSER" protocol registration done in smb-browse
Comment # 4
on bug 10545
from Matthieu Patou
(In reply to Michael Mann from comment #3)
> (In reply to Matthieu Patou from comment #2)
> > See the title:
> > '"BROWSER" protocol
> > registration done in smb-browse conflicts with the "BROWSER" protocol from
> > the pidl generated dissector'
>
> > Basically if we keep this name for the
> > packet-smb-browse.c it prevents from updating the packet-dcerpc-browser.c
> > using latest version of PIDL.
>
> But the current name for the dissector in packet-dcerpc_browser.c is
> "rpc_browser". I had just presumed that was intentional or PIDL could
> generate it that way. I didn't realize it was "manually" changed
> (presumably because of the conflict with smb_browser). Overall it looks
> like the dissector was manually created from the start and never went
> through the PIDL (based on the lack of a "DO NOT EDIT" at the top of the
> dissector.)
Well It's not the first time that I complaining about this :-), but obviously
not being able to always regenerate the dissector didn't help to avoid this.
My hope is that once my changes have landed in master of samba, wireshark can
start to enforce that no manual changes are made on the files that are
autogenerated (through some git rules or what so ever).
>
> This patch needs to be submitted to Gerrit regardless, but I think that all
> of the SMB BROWSER filters should also be updated to match the changed
> "filter name" of the dissector if that's the route we're going.
Makes sense, let me have a look at this.
You are receiving this mail because:
- You are watching all bug changes.
