Wireshark · Wireshark-bugs: [Wireshark-bugs] [Bug 10292] install_desktop_files fails with out-of-tree builds

[bugzilla-daemon@xxxxxxxxxxxxx]

Comment # 2 on bug 10292 from Guy Harris

And the texinfo file for the GNU package from which it comes says:

‘-T’
‘--no-target-directory’
    Do not treat the last operand specially when it is a directory or a
symbolic link to a directory. This can help avoid race conditions in programs
that operate in a shared area. For example, when the command ‘mv /tmp/source
/tmp/dest’ succeeds, there is no guarantee that /tmp/source was renamed to
/tmp/dest: it could have been renamed to /tmp/dest/source instead, if some
other process created /tmp/dest as a directory. However, if mv -T /tmp/source
/tmp/dest succeeds, there is no question that /tmp/source was renamed to
/tmp/dest.

so I *guess* it, for example, protects against
$(DESTDIR)/usr/share/mime/packages/wireshark.xml being a directory in

    install -m 644 -T wireshark-mime-package.xml
$(DESTDIR)/usr/share/mime/packages/wireshark.xml

I think that's unlikely enough to be an issue; if somebody really truly cares,
they can either make a local modification or can submit a patch *that includes
a configure script check to see whether install supports a -T flag that has
that behavior* (FreeBSD's install has a -T flag that takes an argument and that
has quite different behavior, so do *NOT* assume that, if install takes a -T
flag, it takes the GNU coreutils install -T flag!) and only uses it if so.

---

      You are receiving this mail because:

• You are watching all bug changes.