Wireshark-bugs: [Wireshark-bugs] [Bug 9962] Buildbot crash output: fuzz-2014-04-07-13431.pcap
Comment # 9
on bug 9962
from Guy Harris
Actually, lbm_channel_is_known() checks
lbm_channel_is_unknown_transport_lbttcp(), which checks both
lbm_channel_is_unknown_transport_source_lbttcp() and
lbm_channel_is_unknown_transport_client_lbttcp().
So lbm_channel_is_unknown_transport_lbttcp(channel) will be true if
lbm_channel_is_unknown_transport_source_lbttcp(channel) is true or
lbm_channel_is_unknown_transport_client_lbttcp(channel) is true.
So:
lbm_channel_is_known() is:
gboolean lbm_channel_is_known(guint64 channel)
{
return (!lbm_channel_is_unknown_transport_lbttcp(channel) &&
!lbm_channel_is_unknown_stream_tcp(channel));
}
so it'll be false iff lbm_channel_is_unknown_transport_lbttcp(channel) is true
or lbm_channel_is_unknown_stream_tcp(channel) is true, so it'll be false if any
of lbm_channel_is_unknown_transport_source_lbttcp(channel),
lbm_channel_is_unknown_transport_client_lbttcp(channel), or
lbm_channel_is_unknown_stream_tcp(channel) are true.
So we know that:
one of lbm_channel_is_unknown_transport_source_lbttcp(channel),
lbm_channel_is_unknown_transport_client_lbttcp(channel), or
lbm_channel_is_unknown_stream_tcp(channel) is true;
lbm_channel_is_unknown_transport_source_lbttcp(channel) is not true;
lbm_channel_is_unknown_transport_client_lbttcp(channel) is not true;
so lbm_channel_is_unknown_stream_tcp(channel) is true.
So if channel is LBM_CHANNEL_UNKNOWN_STREAM_TCP:
lbm_channel_is_unknown_transport_source_lbttcp(channel) is false, so the
address and port won't be set from the TCP source;
lbm_channel_is_unknown_transport_client_lbttcp(channel) is false, so the
address and port won't be set from the TCP destination;
both of those are false, so
lbm_channel_is_unknown_transport_lbttcp(channel) is false;
lbm_channel_is_unknown_transport_lbttcp(channel) is false,
lbm_channel_is_unknown_stream_tcp(channel) is true, so
lbm_channel_is_known(channel) is false, so, on the first pass, if
tcp_sid_info.set is true, *boom*.
You are receiving this mail because:
- You are watching all bug changes.