Wireshark · Wireshark-bugs: [Wireshark-bugs] [Bug 9933] Questionable calling of ethernet dissector by encapsulating protocol dis

[bugzilla-daemon@xxxxxxxxxxxxx]

Comment # 3 on bug 9933 from Hadriel Kaplan

Also, aren't there really 4 cases?
1) When you know it does not have an FCS.
2) When you know it does have an FCS.
3) When you don't know, and the ethernet dissector should check the
pseudo-header.
4) When you don't know and ethernet should NOT check the pseudo-header.

Because right now if you disable the assume_fcs pref, dissect_eth_maybefcs()
checks the pseudo-header. If you enable the assume_fcs pref, then it knows
there're 4 bytes. There's no way to not know and not have it check the
pseudo-header.

Actually maybe what we need is a pref for assume_no_fcs, or change assume_fcs
to be an enum of yes-no-not type thing?

---

      You are receiving this mail because:

• You are watching all bug changes.