Wireshark-bugs: [Wireshark-bugs] [Bug 9732] New: Lua: recent commit changed some MENU_ key names
Date: Fri, 07 Feb 2014 18:25:45 +0000
Bug ID 9732
Summary Lua: recent commit changed some MENU_ key names in init.lua
Classification Unclassified
Product Wireshark
Version 1.11.x (Experimental)
Hardware x86
OS Mac OS X 10.9
Status UNCONFIRMED
Severity Normal
Priority Low
Component Dissection engine (libwireshark)
Assignee bugzilla-admin@wireshark.org
Reporter hadrielk@yahoo.com

Build Information:
wireshark 1.11.3 (wireshark-1.11.3-rc1-1585-ga7b1567-dirty from master)

Copyright 1998-2014 Gerald Combs <gerald@wireshark.org> and contributors.
This is free software; see the source for copying conditions. There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

Compiled (64-bit) with GTK+ 2.24.22, with Cairo 1.12.16, with Pango 1.36.1,
with
GLib 2.38.2, with libpcap, with libz 1.2.8, without POSIX capabilities, without
SMI, without c-ares, without ADNS, with Lua 5.2, without Python, with GnuTLS
3.1.10, with Gcrypt 1.5.3, with MIT Kerberos, without GeoIP, without PortAudio,
with AirPcap.

Running on Mac OS X 10.9.1, build 13B42 (Darwin 13.0.0), with locale
en_US.UTF-8, with libpcap version 1.5.3, with libz 1.2.8, GnuTLS 3.1.10, Gcrypt
1.5.3, without AirPcap.
Intel(R) Core(TM) i7 CPU       M 620  @ 2.67GHz

Built using clang 4.2.1 Compatible Apple LLVM 5.0 (clang-500.2.79).
--
A recent fix (made by me) for bug 9707, in Change-Id:
If4ee1906aa60dd37366cf2ef9bc4168e0ea024b6, made the perl regex grab too much of
the menu name.  It changed MENU_STAT_CONVERSATION, MENU_STAT_RESPONSE, and
MENU_ANALYZE_CONVERSATION's key names into their longer C-code names.  Ugh.

The fix for this is trivial (though brittle), but anyway I want to prevent such
things from happening in the future *for anything in wslua* so I plan to create
a test script as well.  But I'll submit that test portion separately, as it's
not directly related and might cause problems if someone needs to cherry-pick
this bug's fix.


You are receiving this mail because:
  • You are watching all bug changes.