Wireshark-bugs: [Wireshark-bugs] [Bug 9573] Global Variable in x509af dissector causing problems
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Tue, 07 Jan 2014 22:22:55 +0000

Comment # 7 on bug 9573 from 
Michael, your patch does fix the valgrind error. It also causes one minor
change to the dissection (detected by diffing output of two tshark runs). A
malformed packet that used to generate ei_ber_oid_not_implemented now generates
ei_ber_no_oid instead.

However, this seems correct to me - previously the OID value at
packet-ber.c:1086 would be garbage, pass the NULL-check, then fail the
subsequent check. Now the OID value is correctly NULL and fails the earlier
check.

I can't guarantee there isn't some other peculiar side-effect, but at this
point I'm happy if you want to commit your patch.

You are receiving this mail because:
  • You are watching all bug changes.