Wireshark-bugs: [Wireshark-bugs] [Bug 9612] Dissector of AMQP 1.0
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Tue, 07 Jan 2014 13:11:00 +0000

Comment # 6 on bug 9612 from 
(In reply to comment #5)
> Thanks for the feedback, I am applying your suggestions. As the FT_NONE ->
> FT_.. replacement is quite tricky (many AMQP types can be decoded as uint8
> or uint16 or so, depending on type descriptor; hence I have to dynamically
> change/set proper ft_amqp_1_0_* variable after decoding the descriptor), it
> will take very few weeks to propose new version of patch.

Dynamically setting ft_ values really shouldn't be necessary (and is generally
avoided as bugs in it can be really hard to track down).

I was thinking of fields like hf_amqp_1_0_creationTime which (if I am reading
the APQM spec correctly) are required to be timestamps and therefore can be
statically set to type FT_TIME. In fact, skimming the spec there are very few
fields whose type is actually listed as "*" (which presumably means it can be
many things depending on the type descriptor).

(spec I found, hopefully the right one:
http://docs.oasis-open.org/amqp/core/v1.0/amqp-core-complete-v1.0.pdf)

You are receiving this mail because:
  • You are watching all bug changes.