Wireshark-bugs: [Wireshark-bugs] [Bug 9607] TFShark (Terminal FileShark)
Date: Wed, 01 Jan 2014 14:14:03 +0000

changed bug 9607

What Removed Added
Attachment #12404 is obsolete   1
Attachment #12404 Flags review_for_checkin?  
Attachment #12408 Flags   review_for_checkin?

Comment # 9 on bug 9607 from
Created attachment 12408 [details]
TFShark v.002

I added a VERY PRELIMINARY version of the "filetap" library to r54531.   This
patch works with that version of the library as well as hooks it in with the
rest of the build system (which was intentionally left out of r54531)

This patch is the first attempt at replacing wiretap for fileshark to use. 
Unfortunately, I still have a link issue with wiretap with the provided patch. 
There is still a very engrained/dependent relationship between wtap,
capture_file, and the "file helper routines" of file.c.  The capture_file
structure seems too much a for a generic file, so I want filetap to use
something else, but that means duplicating a lot of the current code.

Evan, 
Do you think the link issue (and the other wtap/capture_file/"file helper" 
stuff) could/should be avoided with your notion of "new_file_based_tvb"?  Right
now I'm not seeing the connection (and thought the tvb stuff would be on top of
wtap(ftap)/capture_file/etc)

I'm posting this patch and committed the filetap library so that others can
look at it and provide comments.  The functionality is ballooning farther than
I originally anticipated and I want to make sure I'm using/setting up the right
building blocks.


You are receiving this mail because:
  • You are watching all bug changes.