Wireshark-bugs: [Wireshark-bugs] [Bug 9472] ANSI IS-637 SMS enhancements for CMAS (TIA-1149) and
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Thu, 19 Dec 2013 17:22:28 +0000

Comment # 8 on bug 9472 from 
1. okay

2. I didn't add that parameter someone else did, they changed it from using the
private_data pointer.  The parameter is used the ...user_data element calls
dis_field_udh() based on that parameter being set true in one of the other
element dissectors.  Not my design.  However, this is the same thing you wanted
me to do to get rid of the globals in packet-ansi_a.c!

3.  I took a pass through for those but yes I still see a few.

4.  In this case there is no good reason.  In some of the other dissectors I
have done this because typcially I don't want to use 16-bit bitmasks mixed in
with 8-bit bitmasks.  I don't like the way it looks.  So it really depends on
all of the fields combined.  I will change these ones because there isn't any
visual reason for it to kept this way.

You are receiving this mail because:
  • You are watching all bug changes.