Wireshark-bugs: [Wireshark-bugs] [Bug 9512] dtls: fix buffer overflow in mac check
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Sat, 14 Dec 2013 01:09:34 +0000

Comment # 17 on bug 9512 from 
(In reply to comment #16)
> There is no strong reason why it is not using hex_str_to_bytes. I considered
> using it, but then favored to use the from_hex function because it is
> simpler and does not convert the hex string "123" to "12 03" (instead, it
> errors out).
> 
> Erroring out (in the debug log, not visually) is maybe too strict though.
> Converting it to "12 03" is still not correct ("01 23" is), but perhaps this
> kind of errors could be marked in the UI where keys can be inserted?

Other dissectors (802.11 & 802.15.4) have similar key preferences so it would
be nice if they behaved consistently. Given that converting a string of hex
digits to a byte array is a pretty common task in a protocol analysis, if
hex_str_to_bytes doesn't have the desired behavior then that might indicate a
problem with our API.

You are receiving this mail because:
  • You are watching all bug changes.