Wireshark-bugs: [Wireshark-bugs] [Bug 9507] AC_WIRESHARK_COMPILER_FLAGS_CHECK / AC_WIRESHARK_GCC
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Wed, 04 Dec 2013 19:51:14 +0000

Comment # 1 on bug 9507 from 
(In reply to comment #0)
> The correct solution would be for the macro to not touch CFLAGS_FOR_BUILD
> unless it's checking against CC_FOR_BUILD, or at all.

The correct solution would be for the macro to, if CC and CC_FOR_BUILD are
different, check *both* compilers, and modify CFLAGS based on the results of
testing CC and modify CFLAGS_FOR_BUILD based on the results of testing CC. 
That way, we crank up the warnings even when building build tools, which is a
Good Thing.

If we are to fix this for 1.10.x or 1.8.x, perhaps not modifying
CFLAGS_FOR_BUILD unless CC = CC_FOR_BUILD is a good simple fix, but that's not
what we should do for 1.11.x or the future 1.12.x.

You are receiving this mail because:
  • You are watching all bug changes.