Wireshark-bugs: [Wireshark-bugs] [Bug 9424] Implement ZigBee Green Power dissector
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Mon, 02 Dec 2013 11:01:43 +0000

Comment # 12 on bug 9424 from 
1. The engineers of DSR provided the new patch today (for revision 53717).
Please check it.

2. Fixed. Since Green Power is a profile of ZigBee NWK layer, the display
filter names should start with "zbee_nwk_gp" (by analogy with zbee_zcl_ha
profile already used in packet-zbee.h). Done.

3. There were no logic changes to dissect_zbee_nwk_heur(). We used
do...while(FALSE) since it's very handy to use breaks inside it to go outside
and no goto ever required). But if this style doesn't suit Wireshark code
conventions, we reverted these modifications in the newest patch. Fixed.

4. There were no of #defines in packet-zbee-nwk-gp.h used outside of
packet-zbee-nwk-gp.c. So, we combined these two files to packet-zbee-nwk-gp.c.

5. Fixed too.

Best regards,
DSR Corporation.

You are receiving this mail because:
  • You are watching all bug changes.