Wireshark-bugs: [Wireshark-bugs] [Bug 9263] Buildbot crash output: fuzz-2013-10-10-12811.pcap
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Thu, 31 Oct 2013 07:50:27 +0000

Comment # 15 on bug 9263 from 
(In reply to comment #12)
> Comment on attachment 11777 [details]
> Change the error return value of tvb_[reported_]length_remaining() from -1
> to 0.

The following comment change in tvbuf.h looks misleading to me:

 /** Computes bytes to end of buffer, from offset (which can be negative,
   * indicate that offset is out of bounds. No exception is thrown. */

Nothing remaining is a valid situation while trying to access out of bounds
data is not: The latter indicates either a programming error or an invalid
packet.
I'm not happy with that change.

You are receiving this mail because:
  • You are watching all bug changes.