Wireshark · Wireshark-bugs: [Wireshark-bugs] [Bug 9339] Add wifi display port to the RTSP dissector

[bugzilla-daemon@xxxxxxxxxxxxx]

Comment # 7 on bug 9339 from chaitanya

(In reply to comment #6)
> (In reply to comment #5)
> > 
> > Review of other dev ? (about use pref enum ?)
> 
> 
> I'm not sure what is meant by "pref enum". 
> Use of a range seems OK to me.
> 
Even i am not sure? Alex, can you elaborate?

> On a separate note:
> prefs_register_obsolete_preference should be used to indicate that the
> existing two preferences are now obsolete.
> 
> (Fromm doc/README.dissector:
> 
> Note that a warning will pop up if you've saved such preference to the
> preference file and you subsequently take the code out. The way to make
> a preference obsolete is to register it as such:
> 
> /* Register a preference that used to be supported but no longer is. */
>     void prefs_register_obsolete_preference(module_t *module,
>         const char *name);

I wasn't aware of that....will submit a new patch with this change.
Thanks for the comments.

---

      You are receiving this mail because:

• You are watching all bug changes.