Wireshark-bugs: [Wireshark-bugs] [Bug 9344] New: remove redundant or use faster col_xxx function
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Tue, 29 Oct 2013 11:50:01 +0000
Bug ID 9344
Summary remove redundant or use faster col_xxx functions
Classification Unclassified
Product Wireshark
Version SVN
Hardware x86
OS All
Status UNCONFIRMED
Severity Trivial
Priority Low
Component Wireshark
Assignee bugzilla-admin@wireshark.org
Reporter dgautheron@magic.fr 

Created attachment 11920 [details]
replace col_add_str with faster col_set_str

Build Information:

--
Hi,

mostly sed replace stuff:

patch 1
- when the text parameter is constant col_add_str() and col_set_str() are
equivalent but col_set_str() is faster.

patch 2
- same for  replace col_append_fstr and col_append_str 

patch 3
- remove col_clear() when it's redundant:
    - before a col_set/col_add if the dissector can't throw an exception.

- replace col_append() after a col_clear() with faster col_add... or col_set


Regards
Didier

You are receiving this mail because:
  • You are watching all bug changes.