Wireshark-bugs: [Wireshark-bugs] [Bug 9244] Latest WSMP protocol support
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Tue, 22 Oct 2013 14:50:38 +0000

Comment # 10 on bug 9244 from 
I've made some changes in SVN #52761: 

See https://anonsvn.wireshark.org/viewvc?revision=52761&view=revision

The most significant change was to remove the 'if (tree)'. (See the revision
comment for the details about how a call to an external dissector really
shouldn't be done under an 'if (tree)' & etc).

(I may decide to "special case" a call to the data dissector and put everything
under the 'if (tree)' as was done in the previous version of the dissector.

In any case, adjusting 'offset' under an 'if (tree)' but then using 'offset'
outside of the 'if (tree)' (thus with different values depending upon 'tree ==
NULL') is problematic.

If I've messed anything up, please let me know.

Thanks

You are receiving this mail because:
  • You are watching all bug changes.