Comment # 13
on bug 8818
from Evan Huus
(In reply to comment #12)
> To be sure: accepting for file-format patches are stopped or can I help with
> something?
I believe the last time this got discussed was [1], where we concluded that we
would continue to accept file-format patches, but not substantial GUI or
wiretap changes to support them.
Practically, I think the lack of review lately is mostly a lack of manpower, I
don't think there's any philosophical reason that this particular patch hasn't
been touched.
I have no major concerns on a quick review, just a few questions:
- Should get_dwarf_length be in dwarf.c or is it something specific to
dwarf-in-elf? If so, the name should probably reflect that somehow.
- There is at least one place where you use wmem_alloc+g_snprintf that I think
wmem_strdup_printf would be simpler? Unless the length limitation is important,
which is difficult to tell from reading the code.
- For consistency with file-mp4.c (which I think is how we agreed to do
file-type dissection going forward) please call it file-elf.c and add it
FILE_DISSECTOR_SRC instead of DISSECTOR_SRC. I don't think the cmake build
system has an equivalent yet.
Sorry for the delays,
Evan
[1] https://www.wireshark.org/lists/wireshark-dev/201306/msg00101.html
You are receiving this mail because:
- You are watching all bug changes.
