Wireshark-bugs: [Wireshark-bugs] [Bug 8674] [PATCH] - GigE Vision GVCP dissector
Date: Thu, 17 Oct 2013 03:04:34 +0000

Comment # 15 on bug 8674 from
Comment on attachment 11730 [details]
GVCP Dissector patch

1. Is the XML file something that vendors already have or did you create this
format speoifically for this dissector?  If it was just created, perhaps a UAT
would be just as good (and you get more of the parsing "for free")?

2. Make location of XML file a dissector preference.

This dissector seems to have issues similar to what Roland outlined in
http://www.wireshark.org/lists/wireshark-dev/201310/msg00148.html, with Guy's
suggestion of wsgd in
http://www.wireshark.org/lists/wireshark-dev/201310/msg00164.html.  Would going
with wsgd be a lot cleaner and more flexible than this XML construction?


You are receiving this mail because:
  • You are watching all bug changes.