Wireshark-bugs: [Wireshark-bugs] [Bug 9263] Buildbot crash output: fuzz-2013-10-10-12811.pcap
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Sat, 12 Oct 2013 17:07:01 +0000

Comment # 8 on bug 9263 from 
(In reply to comment #7)
> Created attachment 11777 [details]
> Change the error return value of tvb_[reported_]length_remaining() from -1
> to 0.
> 
> This patch changes the error return value of both tvb_length_remaining() and
> tvb_reported_length_remaining() from -1 to 0.  If this patch is applied,
> then in theory it obviates the need for the 1st patch; however, maybe we
> should apply both of them anyway, just in case this change (-1 -> 0) is ever
> reverted for some reason in the future?  I'll probably commit both unless
> someone thinks this 2nd patch is sufficient.  Either/both are suitable for
> back-porting to both the 1.8 and 1.10 trunks.

Perhaps they should return guints and not gints then? Not sure how much
signed/unsigned pain that causes though.

Either way, nack on the backport, it's an API change.

You are receiving this mail because:
  • You are watching all bug changes.