Wireshark-bugs: [Wireshark-bugs] [Bug 9263] Buildbot crash output: fuzz-2013-10-10-12811.pcap
Date: Sat, 12 Oct 2013 14:51:32 +0000

changed bug 9263

What Removed Added
Attachment #11773 Flags   review_for_checkin?

Comment # 5 on bug 9263 from
Created attachment 11773 [details]
Don't assume tvb_[reported_]length_remaining() always return a positive value.

With this quick patch, the following warnings are no longer present:

10:43:39          Warn Dissector bug, protocol TCP, in packet 22525:
reassemble.c:1214: failed assertion "tvb_bytes_exist(tvb, offset,
frag_data_len)"
10:43:39          Warn Dissector bug, protocol TCP, in packet 22534:
reassemble.c:1214: failed assertion "tvb_bytes_exist(tvb, offset,
frag_data_len)"
10:43:39          Warn Dissector bug, protocol TCP, in packet 25209:
reassemble.c:1214: failed assertion "tvb_bytes_exist(tvb, offset,
frag_data_len)"
10:43:39          Warn Dissector bug, protocol TCP, in packet 25321:
reassemble.c:1214: failed assertion "tvb_bytes_exist(tvb, offset,
frag_data_len)"

I've wondered in the past if tvb_length_remaining() and
tvb_reported_length_remaining() should just return 0 instead of -1.  I still
wonder.


You are receiving this mail because:
  • You are watching all bug changes.