Wireshark-bugs: [Wireshark-bugs] [Bug 9229] Add new function in strutil.c to replace non-printab
Guy Harris
changed
bug 9229
| What |
Removed |
Added |
| Hardware |
x86-64
|
All
|
| OS |
Windows 7
|
All
|
Comment # 4
on bug 9229
from Guy Harris
(In reply to comment #3)
> This new function will be used in the next patch for the packet-mq
> dissector, as I display sometime value in both ASCII/EBDIC.
The only time that makes sense is if you cannot determine whether the value is
an ASCII string or an EBCDIC string; if you know it's ASCII, there is no good
reason to display it as EBCDIC, and if you know it's EBCDIC, there is no good
reason to display it as ASCII.
Are there cases where the dissector cannot determine whether it's ASCII or
EBCDIC?
> For to display such string, there is no need of the escape, only dot are
> sufficient. If we need the datail of the dots, we can look in the hex
> display in the 3rd panel directly
So that's presumably the reason why you don't just use format_text().
It's probably best if Wireshark is consistent about how it handles non-graphic
characters; I don't know of a good reason to treat them differently for
different protocols.
Whether they should be shown as escapes, dot, or some Unicode character such as
the substitute character, whether different non-graphic characters should be
handled differently (for example, showing characters with non-numeric C escapes
as the C escapes in question and showing others as dot or substitute), or
whether there should be a user preference to control the display, is another
matter.
You are receiving this mail because:
- You are watching all bug changes.
