Wireshark-bugs: [Wireshark-bugs] [Bug 8942] Unrecognized preferences and color filters created i
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Thu, 18 Jul 2013 20:32:48 +0000

Comment # 13 on bug 8942 from 
(In reply to comment #8)
> (In reply to comment #6)
> Created attachment 11220 [details]
> The version
> should be compatable with all platforms
> 

With this patch I get a
> segmentation fault when launching Wireshark on my Debian Lenny box.
The
> following cast

GString *firstl = (GString *)pf;

give me a structure where
> pf->str is invalid, leading to a crash when doing:

if (strncmp(firstl->str,
> " Configuration file for ", 24) == 0) {

If I understood properly, the
> purpose here is to read the first line of the file. Why not use fgets? Did I
> miss something?

Pascal, no it was I who missed something. I should have used fgets because it's
safer and more straightforward as you can see in the patch I just uploaded. 
Thanks for your input and thanks for not backing out the entire patch. Cheers.

You are receiving this mail because:
  • You are watching all bug changes.