Wireshark-bugs: [Wireshark-bugs] [Bug 8917] Enhancements to SEL FM Dissector
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Sat, 13 Jul 2013 14:49:39 +0000

changed bug 8917

What Removed Added
Attachment #11179 Flags review_for_checkin? review_for_checkin+

Comment # 5 on bug 8917 from 
Comment on attachment 11179 [details]
selfm Dissector patch 07-10-2013

Made a commit based on this patch in r50555. I converted the data_region lookup
to use a tree instead of an slist so you have a more useful example to work off
of.

Two other thoughts (neither worth blocking the patch for):

- The comment block for the fastser_dataregion struct seems chopped off?

- I've noticed you occasionally use proto_tree_add_text for real data values
(and not just for something to hang a subtree off of). This is discouraged,
since those values cannot be filtered on. There are also instances of
proto_item_append_text (like the ones for region_lookup) that would be more
useful as their own generated tree item so that they can be filtered on as
well.

You are receiving this mail because:
  • You are watching all bug changes.