Wireshark-bugs: [Wireshark-bugs] [Bug 8922] patch: (packet-scsi-osd.c) dissect OSD-2 service act
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Fri, 12 Jul 2013 10:17:03 +0000

Comment # 9 on bug 8922 from 
Hi,
Ok ! for indent

about the code :
i don't compile under my ubuntu box :

packet-scsi-osd.c:866:15: error: comparison between signed and unsigned integer
expressions [-Werror=sign-compare]
packet-scsi-osd.c:839:29: error: 'extra_data' may be used uninitialized in this
function [-Werror=maybe-uninitialized]

Also why kept dissect_osd_collection_object_id function ? (it is only a call of
proto_tree_add_item...

You are receiving this mail because:
  • You are watching all bug changes.