Wireshark-bugs: [Wireshark-bugs] [Bug 8912] IxVeriWave 11ac patch
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Wed, 10 Jul 2013 19:00:48 +0000

changed bug 8912

What Removed Added
Attachment #11176 is obsolete   1
Attachment #11183 Flags   review_for_checkin?

Comment # 8 on bug 8912 from 
Created attachment 11183 [details]
Third submitted 11ac patch

Removes the C++ style comments
Fixes white space consistency to use all spaces (this was the guidance given me
earlier)
Fixes hf_radiotap_fcs_bad checkhf error

On the #defines issue raised in the last update, I'll agree that there is a
more elegant way of doing this, but using #defines won't work as the offset
values change based on the card type that created the capture file.  I elected
not to touch this as part of the refactoring because "it works".  These
indirect offsets have been part of the system for many years and I am uneasy
about including a refactoring of this as part of a badly needed update to the
parser/dissector for 11ac.

You are receiving this mail because:
  • You are watching all bug changes.