Wireshark-bugs: [Wireshark-bugs] [Bug 8832] patch: add support for OSD-2/3 in the SCSI dissector
Javier Godoy
changed
bug 8832
| What |
Removed |
Added |
| Attachment #11055 is obsolete |
|
1
|
| Attachment #11118 Flags |
|
review_for_checkin?
|
Comment # 9
on bug 8832
from Javier Godoy
Created attachment 11118 [details]
patch
Build Information:
Version 1.10.0 (SVN Rev 49790 from /trunk-1.10)
iSCSI/SCSI dissectors and expert.c from revision 50300
Patch from bug 8803 (optional, if that patch is not applied reassembling should
be disabled)
Requested issues fixed:
- Consistent use of the osd2_ prefixes
- Compilation errors (-Wall -pedantic-errors).
- Remove dissect_osd_immed_tr (unused)
- Use the new expert info API
- The following expert info fields were added:
ei_osd_attr_unknown, (PI_UNDECODED, PI_NOTE, "Unknown attribute, cannot
decode attribute value")
(common to both OSD and OSD-2, applied to former code, just PI_NOTE
because unknown attributes may be vendor specific attributes, or attributes
that we haven't implemented yet)
ei_osd2_invalid_offset (PI_UNDECODED, PI_ERROR, "Invalid offset exponent")
(OSD-2 specific, the get/set/retrieved attributes segment will not be
decoded because its offset is malformed)
In addition to the requested changes:
- The following service action code was #defined
OSD_2_CREATE_PARTITION 0x888b
- Update scsi_osd_svcaction_vals accordingly
- Remove commented entries from scsi_osd_svcaction (OSD2 commands that are not
implemented in this patch)
- Values of service action codes constants are now #defined with lowercase
digits, for consistence with already defined values.
- Define all the standard attribute pages in attributes_page_vals.
- Changes in dissect_osd_attribute_data_out, case 3 (attribute list): dissect
the set attributes segment.
- The following trees were added (previously the get attributes segment was
dissected at the protocol level, and the set attributes segment was not
dissected)*:
ett_osd_get_attributes,
ett_osd_set_attributes
*I think we could make a better use of trees for this part (e.g. one tree per
attribute), but that would be easier to discuss in a later patch; for now, I
carried on the approach from the existing code.
You are receiving this mail because:
- You are watching all bug changes.
