Wireshark-bugs: [Wireshark-bugs] [Bug 8832] patch: add support for OSD-2/3 in the SCSI dissector
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Sat, 29 Jun 2013 14:36:34 +0000

Comment # 8 on bug 8832 from 
>  You add one hf_scsi_osd2_ variable but several others that are just prefixed hf_scsi_osd_ - should the others also be osd2?

I agree, that approach provides a more consistent rule for naming fields:

- If the field was defined in OSD-1 and it is reused in OSD-2 with the same
format, the same field is used (and it is prefixed with hf_scsi_osd_)
- If the field was not defined in OSD-1, it is prefixed with hf_scsi_osd2_


I will fix that and the other issues and resubmit.

You are receiving this mail because:
  • You are watching all bug changes.