Wireshark-bugs: [Wireshark-bugs] [Bug 8718] ZigBee ZCL Identify cluster not managed
Comment # 19
on bug 8718
from Fabio Tarabelloni
I have merged the two patch in a single one. Is it mandatory I have to split
the patch to 2 single patches ?
(In reply to comment #17)
> (In reply to comment #15)
> > One question: where are Basic cluster and Identify cluster dissector placed?
> > In patch a) or patch b) ? Because their patches are already uploaded but not
> > completed. I think I have to place basic and identify mods in patch b).
>
> If I understand correctly, that code is getting moved *and* getting updated?
> In which case it should (ideally) live in both patches. The first patch
> moves the existing code as-is, and the second patch updates the code in its
> new location. Admittedly, this is hard to do if you're not using git, so if
> they get a little mixed together that's fine.
You are receiving this mail because:
- You are watching all bug changes.