Wireshark-bugs: [Wireshark-bugs] [Bug 8718] ZigBee ZCL Identify cluster not managed
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Sun, 16 Jun 2013 02:03:51 +0000

Comment # 14 on bug 8718 from 
Hi Fabio, looks pretty good. Two requests:

- Provide two patches if possible, one where you reorganize and one where you
actually add the new dissection. Otherwise it's very hard to review what's
actually changed vs just what's been moved.

- The buffer passed to BASE_CUSTOM dissectors is of size ITEM_LABEL_LENGTH, not
ZBEE_ZCL_DISPLAY_BUFFER_MAX_SIZE.

You are receiving this mail because:
  • You are watching all bug changes.