Wireshark-bugs: [Wireshark-bugs] [Bug 8691] Adding support of BGP flow spec RFC 5575
Date: Sat, 15 Jun 2013 01:17:27 +0000

changed bug 8691

What Removed Added
Attachment #10981 Flags review_for_checkin? review_for_checkin-

Comment # 31 on bug 8691 from
Comment on attachment 10981 [details]
SVN DIff RFC 5575 new flavour with append and more items

Please make the "tag" strings passed into the modified functions hf_ items
instead and the proto_tree_add_text that displays them could be switched to a
proto_tree_add_item, using an hf_ passed in rather than the string.

Philosophically I'm torn as to how much "child data" needs to be displayed on
the "parent" tree (ie the proto_item_append_text stuff).  Makes the code a
little messier, but does limit the "drilldown" necessary on the GUI tree.


You are receiving this mail because:
  • You are watching all bug changes.