Wireshark-bugs: [Wireshark-bugs] [Bug 8635] enhanced WCCP decoder
Date: Wed, 05 Jun 2013 13:57:33 +0000

changed bug 8635

What Removed Added
CC   jeff.morriss.ws@gmail.com

Comment # 20 on bug 8635 from
I think at least some of these DISSECTOR_ASSERT()s should be replaced with
expert infos. For example this one:

  DISSECTOR_ASSERT(capability_val_len == 4); 

is checking on the value which was read from the packet (not whether the
dissector's code has a bug--which is what DISSECTOR_ASSERT() is supposed to be
for).

For example, this assert shows up if you load the fuzz'd PCAP file I'm about to
attach.  (This file caused a crash which I fixed in r49783.)


You are receiving this mail because:
  • You are watching all bug changes.