Wireshark · Wireshark-bugs: [Wireshark-bugs] [Bug 8644] New Dissector - SEL RTAC (Real Time Automation Controller) EIA-232 Seria

[bugzilla-daemon@xxxxxxxxxxxxx]

Comment # 13 on bug 8644 from Pascal Quantin

Hi Chris,

will you provide an updated patch using the newly allocated
LINKTYPE_RTAC_SERIAL/DT_RTAC_SERIAL 250?

BTW, on top of the previous comment for the header I saw a small typo in
dissect_rtacser:

    /* Check for a RTAC Serial packet.  It should be at least 12 bytes */
    if(length < 12) {

        return tvb_length(tvb);
    }
should be
    /* Check for a RTAC Serial packet.  It should be at least 12 bytes */
    if(length < 12) {

        return 0;
    }

The following code:
        /* If no payload dissector has been selected, indicate to the user the
preferences options */
        if ((tvb_reported_length_remaining(tvb, offset) > 0) &&
(global_rtacser_payload_proto == RTACSER_PAYLOAD_NONE)) {
            data_payload = proto_tree_add_item(tree, hf_rtacser_data, tvb,
offset, -1, ENC_NA);
            proto_item_set_text(data_payload,"Payload Protocol not selected. 
Check 'Preferences-> Protocols-> RTAC Serial' for options");
        }

could be integrated in the switch on global_rtacser_payload_proto variable, or
a return could be added after the proto_item_set_text to avoid executing the
switch/case.

---

      You are receiving this mail because:

• You are watching all bug changes.