Wireshark-bugs: [Wireshark-bugs] [Bug 8034] Friendly Names support causing unnecessary delay whe
Mike Garratt
changed
bug 8034
| What |
Removed |
Added |
| Attachment #10842 Flags |
|
review_for_checkin?
|
Comment # 4
on bug 8034
from Mike Garratt
Created attachment 10842 [details]
disable_friendly_name_when_capture_child_mode_plus_improved_instrumentation_against_rev_49584
Sorry for the delayed response, been busy at work and missed the emails.
I have reviewed the patch and agree with the approach.
While testing the patch I actually added some instrumentation, and have
included a revised patch that includes the instrumentation as well as patches
into the current source cleanly (the source has changed a bit since the
original patch).
Instrumentation enhancements now show how long the calls are taking (see
below).
Lines 3->17 are new, lines 1->14 are repeated for every interface.
On my machine with 9 test interfaces, without the patch, it takes about 8.2
seconds. With just the functions that actually get the friendly names, the
time drops down to 7.1 seconds. With the attached patch I am sitting at around
2.9 to 3.3.
Whatever variant of the patch is accepted, I suggest it is considered for 1.10
if possible, as the additional startup delay will be noticeable for people with
a lot of interfaces.
Thanks,
- Mike
... earlier debug lines removed ...
1. 22:31:55 Capture Msg Capture Interface Capabilities ...
2. 22:31:55 Capture Dbg sync_if_capabilities_open
3. 22:31:55 Capture Info sync_pipe_run_command() starts
4. 22:31:55 Capture Dbg argv[0]: c:\wireshark\wireshark-gtk2\dumpcap
5. 22:31:55 Capture Dbg argv[1]: -i
6. 22:31:55 Capture Dbg argv[2]: \Device\NPF_{312... ...}
7. 22:31:55 Capture Dbg argv[3]: -L
8. 22:31:55 Capture Dbg argv[4]: -Z
9. 22:31:55 Capture Dbg argv[5]: none
10. 22:31:55 Capture Dbg sync_pipe_open_command
11. 22:31:55 Capture Dbg read 7 indicator: S empty value
12. 22:31:55 Capture Dbg sync_pipe_wait_for_child: wait till child closed
13. 22:31:55 Capture Dbg sync_pipe_wait_for_child: capture child closed after
0.002s
14. 22:31:55 Capture Info sync_pipe_run_command() ends, taking 0.294s,
result=0
15. 22:31:55 Main Info fill_in_local_interfaces() ends, taking 3.210s
16. 22:31:55 Main Info fill_in_local_interfaces() starts
17. 22:31:55 Main Info fill_in_local_interfaces() ends, taking 0.001s
18. 22:31:55 Main Info Wireshark is up and ready to go
You are receiving this mail because:
- You are watching all bug changes.
