Wireshark-bugs: [Wireshark-bugs] [Bug 8708] [PATCH] Add MAC-DATA support to TETRA dissector and
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Thu, 23 May 2013 08:49:10 +0000

changed bug 8708

What Removed Added
CC   pascal.quantin@gmail.com

Comment # 1 on bug 8708 from 
Hi Li Hai,

Thanks a lot for your patch. You will find below a few remarks.

could you explain the following hunk?
@@ -432,54 +440,48 @@

     if(include_carrier_number) {
         carriernumber = tvb_get_guint8(tvb, 1);
-        carriernumber |= 0xff00;
+        carriernumber &= 0xff;
     }
If carriernumber is simply a 8bit value, then there is no need to do a mask,
right?

Regarding your update of the info column, would it make sense to put the
channel whatever the channel type (and not only for BSCH, BNCH and TCH_F)? For
TCH_F, why not put the channel name (to be consistent with your other changes)
rather than a generic "Voice" string?

Moreover do you have a pcap file we could add to the fuzz tests?

Regards,
Pascal.

You are receiving this mail because:
  • You are watching all bug changes.