Wireshark · Wireshark-bugs: [Wireshark-bugs] [Bug 8705] "No such preference" warnings are displayed for 5 obsolete and 1 platfor

[bugzilla-daemon@xxxxxxxxxxxxx]

Comment # 9 on bug 8705 from Cal Turney

(In reply to comment #8)
> (In reply to comment #7)
> (In reply to comment #6)
> > What do you think
> about my removal of the "break"s that follow "return"s
> > such as the five
> in lines 4241-4280?
> 
> Somewhat neutral.  C's switch statement's
> "fallthrough" property is a bit
> weird, and break statements could be
> considered to be an "end this arm of
> the conditional" delimiters, and, as
> such, useful even if they follow a
> return or a goto.

Except when the
> thing being switched on is an enum in which case it's useful to NOT have a
> default case: that way a (good) compiler can warn you that you've missed a
> case.

Thanks to you both for the education.  And, Guy, thanks for relieving me of the
responsibility (OK, the compulsion) to stylistically terraform every file I
happen to be working in. :=)

---

      You are receiving this mail because:

• You are watching all bug changes.