Wireshark-bugs: [Wireshark-bugs] [Bug 8691] Adding support of BGP flow spec RFC 5575
Comment # 18
on bug 8691
from Matt Texier
Hi Alexis,
All changes are all most done but I am suffering with the last one :
+
proto_tree_add_text(subtree3,tvb,q+2,6,"Action flags: %s %s %s",
+
tvb_get_ntohs(tvb,q+6)&0x02 ? "S flag set" : "",
+
tvb_get_ntohs(tvb,q+6)&0x01 ? "T flag set" : "",
+
tvb_get_ntohs(tvb,q+6)&0x00 ? "No Flag" : "");
[...]
+
proto_tree_add_text(subtree3,tvb,q+2,6,"Route Target: %u:%u",
+ tvb_get_ntohs(tvb,
q + 2),
+ tvb_get_ntohl(tvb,
q + 4));
1) First issues was about the hf registration, I do have an error while
launching wireshark :
mtexierarbornet:wireshark matthieu$ ./wireshark
/Users/matthieu/Documents/My-Work/Consulting-Engineering/flowspec_act_ext_com.pcap
(process:41062): Gtk-WARNING **: Locale not supported by C library.
Using the fallback 'C' locale.
Duplicate field detected in call to proto_register_field_array:
bgp.flowspec_ext_com.traffic_sample is already registered
** (process:41062): WARNING **: /Users/matthieu/.wireshark/preferences line
161: No such preference "stream.client.fg" (applying your preferences once
should remove this warning)
** (process:41062): WARNING **: /Users/matthieu/.wireshark/preferences line
162: No such preference "stream.client.bg" (applying your preferences once
should remove this warning)
** (process:41062): WARNING **: /Users/matthieu/.wireshark/preferences line
163: No such preference "stream.server.fg" (applying your preferences once
should remove this warning)
** (process:41062): WARNING **: /Users/matthieu/.wireshark/preferences line
164: No such preference "stream.server.bg" (applying your preferences once
should remove this warning)
** (process:41062): WARNING **: /Users/matthieu/.wireshark/preferences line
224: No such preference "name_resolve_concurrency" (applying your preferences
once should remove this warning)
** (process:41062): WARNING **: /Users/matthieu/.wireshark/preferences line
228: No such preference "name_resolve_load_smi_modules" (applying your
preferences once should remove this warning)
** (process:41062): WARNING **: /Users/matthieu/.wireshark/preferences line
232: No such preference "name_resolve_suppress_smi_errors" (applying your
preferences once should remove this warning)
** (process:41062): WARNING **: /Users/matthieu/.wireshark/preferences line
242: No such preference "taps.rtp_player_max_visible" (applying your
preferences once should remove this warning)
=> just like the bgp.flowspec_ext_com.traffic_sample was already used by
another piece of code. I didn't find it and tried to change a couple of the
type the registry : no joy !
2) Issue : the proto_tree_add_item doesn't work as expected, it have a bitmask
which is 6 bytes long, I am not sure the function is expecting to have such a
large field.
See attached a screen shot of was wireshark displays: no clue what it is !!!
??? "Short Frame" ???
Any hint for this ?
Thanks Matt.
You are receiving this mail because:
- You are watching all bug changes.
